String infoMessage = getInfoMessage();
screenInfoMessage = new String(infoMessage);
// ...
infoMessage = new String(screenInfoMessage);
Thursday, January 27, 2011
Wednesday, January 26, 2011
When in doubt, use a switch
switch (type) {
default:
compositeFactory = new EditorCompositeFactoryImpl(parent, type);
break;
}
default:
compositeFactory = new EditorCompositeFactoryImpl(parent, type);
break;
}
One if statement is not enough
if (compositeMode == DialogMode.UPDATE_MODE) {
hierarchyTabCompositeFactory.setFamily(false);
}
headTabCompositeFactory.bind();
if (compositeMode == DialogMode.UPDATE_MODE) {
hierarchyTabCompositeFactory.setFamily(true);
}
if (compositeMode == DialogMode.UPDATE_MODE) {
hierarchyTabCompositeFactory.bind();
}
hierarchyTabCompositeFactory.setFamily(false);
}
headTabCompositeFactory.bind();
if (compositeMode == DialogMode.UPDATE_MODE) {
hierarchyTabCompositeFactory.setFamily(true);
}
if (compositeMode == DialogMode.UPDATE_MODE) {
hierarchyTabCompositeFactory.bind();
}
Tuesday, January 25, 2011
If not statement
if (article instanceof Article
&& ((Article) article).getArticleCode() == null) {
// NOTHING
} else {
setEnableTitle();
}
&& ((Article) article).getArticleCode() == null) {
// NOTHING
} else {
setEnableTitle();
}
Subscribe to:
Posts (Atom)